Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update webhook validation #16

Merged
merged 2 commits into from
May 13, 2024
Merged

Update webhook validation #16

merged 2 commits into from
May 13, 2024

Conversation

pokornyd
Copy link
Member

Motivation

Fixes #15

Added null coalescing to check both legacy and new header names, parametrized tests accordingly.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@pokornyd pokornyd requested a review from a team as a code owner May 13, 2024 10:42
@pokornyd pokornyd force-pushed the update-validator branch from 9b0552b to d3fba9c Compare May 13, 2024 10:44
@pokornyd pokornyd merged commit 9305cfb into master May 13, 2024
1 check passed
@pokornyd pokornyd deleted the update-validator branch May 13, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanKiral IvanKiral IvanKiral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make webhook signature validator work with new webhooks
2 participants
@pokornyd @IvanKiral